Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api: Length check the array sent to RPC. #11696

Merged
merged 9 commits into from
Mar 11, 2024
Merged

fix: api: Length check the array sent to RPC. #11696

Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9b1550d
Adding length check upto 100
parthshah1 Mar 6, 2024
97fc51a
Update node/impl/full/eth.go
parthshah1 Mar 8, 2024
60028e2
Update node/impl/full/eth.go
parthshah1 Mar 8, 2024
a274f46
Adding global variable called RewardPercentileArrayLimit
parthshah1 Mar 8, 2024
03ccee7
Refactoring
parthshah1 Mar 8, 2024
ba44428
Adding const
parthshah1 Mar 8, 2024
2927fbf
Fixing lint
parthshah1 Mar 9, 2024
952c9b3
Fixing typos
parthshah1 Mar 9, 2024
5d79196
Update node/impl/full/eth.go
rvagg Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions node/impl/full/eth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import (
)

var ErrUnsupported = errors.New("unsupported method")
var RewardPercentileArrayLimit int = 100
parthshah1 marked this conversation as resolved.
Show resolved Hide resolved

type EthModuleAPI interface {
EthBlockNumber(ctx context.Context) (ethtypes.EthUint64, error)
Expand Down Expand Up @@ -689,6 +690,9 @@ func (a *EthModule) EthFeeHistory(ctx context.Context, p jsonrpc.RawParams) (eth
}
rewardPercentiles := make([]float64, 0)
if params.RewardPercentiles != nil {
if len(*params.RewardPercentiles) > RewardPercentileArrayLimit {
return ethtypes.EthFeeHistory{}, fmt.Errorf("Length cannot be greater than 100")
}
rewardPercentiles = append(rewardPercentiles, *params.RewardPercentiles...)
}
for i, rp := range rewardPercentiles {
Expand Down