Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deps: update boxo/libp2p/graphsync #11739

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Mar 18, 2024

Update boxo & libp2p.

Related Issues

Proposed Changes

  • Pulls in the latest version of kubo-api-client (extracted from kubo 0.27.0).
  • Update go-libp2p to v0.33.0
  • Update boxo to v0.18.0
  • Update go-graphsync to v0.16.0

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@Stebalien Stebalien requested a review from a team as a code owner March 18, 2024 19:14
- Pulls in the latest version of `kubo-api-client` (extracted from kubo
  0.27.0).
- Update go-libp2p to v0.33.0
- Update boxo to v0.18.0
- Update go-graphsync to v0.16.0
@Stebalien Stebalien force-pushed the steb/update-ipfs-deps branch from 7779acc to 463a276 Compare March 18, 2024 19:28
@Stebalien Stebalien changed the title chore: update boxo/libp2p/graphsync chore: deps: update boxo/libp2p/graphsync Mar 18, 2024
@Stebalien Stebalien requested a review from rvagg March 19, 2024 00:51
@Stebalien
Copy link
Member Author

This syncs mainnet. I can't guarantee (or test thuroughly) the IPFS client or graphsync logic, but the alternative is ripping it out (it has been deprecated for a while) and we have unit tests.

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the graphsync bump doesn't have much except for Go and libp2p version bumps, but it does have some really nice fixes 👌, it's just a shame that those are useless here and we should probably work on removing graphsync as a direct dependency of lotus

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FINALLY QUIC WHICH WILL BUILD WITH FUTURE GO VERSIONS!! 🚀 🚀

@Stebalien Stebalien merged commit 1047992 into release/v1.26.0 Mar 19, 2024
92 of 94 checks passed
@Stebalien Stebalien deleted the steb/update-ipfs-deps branch March 19, 2024 15:33
rjan90 pushed a commit that referenced this pull request Mar 22, 2024
- Pulls in the latest version of `kubo-api-client` (extracted from kubo
  0.27.0).
- Update go-libp2p to v0.33.0
- Update boxo to v0.18.0
- Update go-graphsync to v0.16.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants