feat(ci): go list check versions available for untagged dependencies #12774
+40
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
rvagg/ci/dependency-checker
branch
from
55edcd9 to
cf21ec5
Compare
|
OK, this works now and reports: first one is a direct dependency and the second is an indirect; I've added an ignore to both, pubsub could be upgraded but I won't do it here, the other one is used by github.com/elastic/go-sysinfo which has an update but still doesn't use a tagged version of plist. |
8 tasks
BigLep
approved these changes
Dec 12, 2024
| @@ -352,7 +352,7 @@ require ( | |||
| gopkg.in/cheggaaa/pb.v1 v1.0.28 // indirect | |||
| gopkg.in/yaml.v2 v2.4.0 // indirect | |||
| gopkg.in/yaml.v3 v3.0.1 // indirect | |||
| howett.net/plist v0.0.0-20181124034731-591f970eefbb // indirect | |||
| howett.net/plist v0.0.0-20181124034731-591f970eefbb // indirect; indirect dependency-check-ignore: required by github.com/elastic/go-sysinfo | |||
There was a problem hiding this comment.
Suggested change
| howett.net/plist v0.0.0-20181124034731-591f970eefbb // indirect; indirect dependency-check-ignore: required by github.com/elastic/go-sysinfo | |
| howett.net/plist v0.0.0-20181124034731-591f970eefbb // indirect; dependency-check-ignore: required by github.com/elastic/go-sysinfo |
extra indirect is redundant?
There was a problem hiding this comment.
yeah, that can be fixed, but this PR is full of conflicts now the base has shifted so I'm going to leave it to @galargh to resolve if he pulls this in, otherwise he can write it the way he wants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #12740, I'm experimenting with using
go list -versionsto inspectv0.0.0dependencies (as per discussion with @BigLep). We should be able to say "you're using an untagged version, but it has a version, that's naughty.