Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measuring test vector coverage #314

Open
Stebalien opened this issue Feb 9, 2022 · 6 comments
Open

Measuring test vector coverage #314

Stebalien opened this issue Feb 9, 2022 · 6 comments
Labels
Hint: Help wanted Extra attention is needed P3 P3: Might get resolved Topic: Built-in actors Topic: Testing
Milestone

Comments

@Stebalien
Copy link
Member

It would be really nice to measure what parts of actors are covered by our current test vectors.

@dtynn
Copy link

dtynn commented Feb 10, 2022

so basically speaking:

  1. tracing & collecting profile data from inside the wasm runtime and make the data human-readable
  2. find some way to enable the tracing only in dev mode (tests & benchmarks)

for step 1,

is that right?

@dtynn
Copy link

dtynn commented Feb 11, 2022

hi @Stebalien
would like to know if wasm-coverage-demo is helpful for this issue ?

@dtynn
Copy link

dtynn commented Feb 12, 2022

completed a simple demo,

and captured a coverage report for executing test-vectors/corpus/extracted/0005-chocolate-01/fil_6_storagemarket/WithdrawBalance/Ok/ext-0005-fil_6_storagemarket-WithdrawBalance-Ok-1.json.

@Stebalien
Copy link
Member Author

tracing & collecting profile data from inside the wasm runtime and make the data human-readable

Yes and yes.

find some way to enable the tracing only in dev mode (tests & benchmarks)

Also yes. We'll have to have some way to compile actors with tracing enabled.

@Stebalien
Copy link
Member Author

completed a simple demo,

That's awesome!

Note: We probably don't need the human readable side of things. As long as the format is compatible with codecov.

@raulk is currently in the process of factoring out the actors into a separate repo (with a single wasm build script so this should be a bit simpler). Once that lands, are you up for making a PR?

@dtynn
Copy link

dtynn commented Feb 16, 2022

Note: We probably don't need the human readable side of things. As long as the format is compatible with codecov.

sure, the reults could be the compatible format, or at least they should be easily converted to, since all the things are generated by llvm-cov

@raulk is currently in the process of factoring out the actors into a separate repo (with a single wasm build script so this should be a bit simpler). Once that lands, are you up for making a PR?

of course :)

@jennijuju jennijuju added this to the Phase 1 milestone Mar 7, 2022
@jennijuju jennijuju added Topic: Testing P2 P2: Should be resolved labels Mar 7, 2022
@raulk raulk added P3 P3: Might get resolved and removed P2 P2: Should be resolved labels Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hint: Help wanted Extra attention is needed P3 P3: Might get resolved Topic: Built-in actors Topic: Testing
Projects
No open projects
Development

No branches or pull requests

4 participants