Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick the per-instance and global memory limits #341

Closed
arajasek opened this issue Jan 14, 2022 · 4 comments
Closed

Pick the per-instance and global memory limits #341

arajasek opened this issue Jan 14, 2022 · 4 comments

Comments

@arajasek
Copy link
Contributor

arajasek commented Jan 14, 2022

Pick the correct per-instance and global memory limit.

@arajasek arajasek changed the title Pick page config params FVM: Pick page config params Jan 14, 2022
@cryptonemo
Copy link
Contributor

I think @raulk had some thoughts on initial values here.

@Stebalien Stebalien transferred this issue from filecoin-project/filecoin-ffi Feb 21, 2022
@jennijuju jennijuju added this to the Phase 1 milestone Feb 21, 2022
@jennijuju jennijuju added P2 P2: Should be resolved Topic: Performance labels Mar 7, 2022
@jennijuju jennijuju modified the milestones: Phase 1, Phase 2 Mar 7, 2022
@raulk
Copy link
Member

raulk commented Mar 9, 2022

For M1 (nv16), we are going with unlimited max pages given that the system can only run trusted logic via builtin system actors. However, it's not clear how many initial pages should be to avoid excessive memory expansion operations. Opened #369 to track that.

@Stebalien will your benchmarks yield a good value for initial pages?

For M2, there's a proposal here: filecoin-project/FIPs#317.

@raulk
Copy link
Member

raulk commented Sep 8, 2022

Need to resurrect this issue for M2.1 (FEVM). In discussions over time we have settled on not charging for memory allocated, but rather for memory expansions. Finding the gas value/formula to charge per expansion will be subject of upcoming work, but for now we should at least set a max pages to a reasonable value (in the past we've discussed 64MiB, 256MiB, or 512MiB, IIRC).

@raulk raulk added Topic: Gas and limits P1 P1: Must be resolved and removed Topic: Performance P2 P2: Should be resolved labels Sep 8, 2022
@maciejwitowski maciejwitowski modified the milestones: M2.1, M2.1 (r8) Topaz Oct 10, 2022
@Stebalien Stebalien changed the title FVM: Pick page config params Pick the per-instance and global memory limits Nov 12, 2022
@maciejwitowski maciejwitowski removed the P1 P1: Must be resolved label Dec 7, 2022
@Stebalien
Copy link
Member

We're sticking with 2GiB for now. Pending FIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants