Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead Code here? #1200

Closed
Dizans opened this issue Jul 6, 2020 · 1 comment · Fixed by #1201
Closed

Dead Code here? #1200

Dizans opened this issue Jul 6, 2020 · 1 comment · Fixed by #1201

Comments

@Dizans
Copy link

Dizans commented Jul 6, 2020

It seems that the mpsc::sync_channel call here does nothing.

rust-fil-proofs/storage-proofs/porep/src/stacked/vanilla/proof.rs

Line 462 in 00a8d95

mpsc::sync_channel::<(Vec<GenericArray<Fr, ColumnArity>>, bool)>(

@porcuquine porcuquine mentioned this issue Jul 6, 2020
Merged
@porcuquine
Copy link
Collaborator

Good catch. #1201 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dead code. filecoin-project/rust-fil-proofs
2 participants
@porcuquine @Dizans