-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage-proofs): zizag, drgporep and por abstract over the hasher in circuits #543
Conversation
0971a3f
to
45c9f3d
Compare
@porcuquine this adds the hasher to the parameter identifiers, so I am guessing we have to change parameters versions again? |
Hmmm, if it only changes the set of parameters generated but doesn't change the circuit/parameters for a given identifier, we don't need to bump the version. (The version is needed so we don't find old parameters by the name with which we request new ones.) But we will need to generate and publish the parameter again. When doing that, remember to clear your cache first, so we don't keep stale parameters around in (It's possible I'm seeing something wrong, so if this sounds mistaken, please flag.) |
a597101
to
e7bfd1d
Compare
This is ready to go from my side. Note this will need new params published again, as now the hasher is part of the cache identifier |
Can you include the param publishing in this PR? That would be the best way to do it and should be our policy. Include a comment here stating that you pinned and verified. |
We should see a diff to |
Looking good, @dignifiedquire. Any chance of extending this to the merklepor example, so we can run that with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Basic tests are passing. Needs some more checks
Ref #531