Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Paych voucher SecretPreimage name is backwards #1059

Closed
ZenGround0 opened this issue Aug 28, 2020 · 3 comments
Closed

Paych voucher SecretPreimage name is backwards #1059

ZenGround0 opened this issue Aug 28, 2020 · 3 comments
Assignees
@laudiacay
Labels
cleanup Technical debt recovery and other cleanup work enhancement New feature or request P3 Not urgent or important
Milestone
QoL Improvements

Comments

@ZenGround0
Copy link
Contributor

During update state we hash params.Secret to get hashedSecret. We then compare and enforce equality on hashedSecret and the voucher's SecretPreimage field. Its clear the secret is the preimage. and the voucher contains the hash. We should change the voucher name to SecretHash
@anorth anorth added cleanup Technical debt recovery and other cleanup work enhancement New feature or request P3 Not urgent or important labels Aug 31, 2020
@ZenGround0
Copy link
Contributor Author

This external document also noticed that the names are backwards see "Other voucher features"

@anorth anorth added the change-state Changes state schema, necessitating major version upgrade/migration label Oct 18, 2020
@ZenGround0
Copy link
Contributor Author

I don't think this will change serialized state just the names used in code.

@ZenGround0 ZenGround0 removed the change-state Changes state schema, necessitating major version upgrade/migration label Oct 28, 2020
@ZenGround0 ZenGround0 mentioned this issue Apr 8, 2021
Closed
28 tasks
@ZenGround0 ZenGround0 added this to the QoL Improvements milestone Aug 12, 2021
@laudiacay laudiacay mentioned this issue Sep 24, 2021
Merged
@laudiacay
Copy link
Contributor

Merged into next.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@laudiacay laudiacay

Labels
cleanup Technical debt recovery and other cleanup work enhancement New feature or request P3 Not urgent or important
Projects
None yet
Milestone
QoL Improvements
Development

No branches or pull requests
3 participants
@anorth @ZenGround0 @laudiacay