Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging Payment Channel Sections #1017

Closed
yiannisbot opened this issue Jul 25, 2020 · 3 comments · Fixed by #1120
Closed

Merging Payment Channel Sections #1017

yiannisbot opened this issue Jul 25, 2020 · 3 comments · Fixed by #1120

Comments

@yiannisbot
Copy link
Collaborator

Currently, payment channels are discussed in two different sections: 2.5.2 as part of Systems and 4.4 as part of Algorithms. Although several parts of the system are discussed in both section 2 and section 4, the distinction between the discussion in the two subsections for Payment Channels in particular is not clear to me.

There is no particular algorithm as such being implemented for Payment Channels - rather the mechanics of how to set them up and operate them are the important point here. That said, I would like to merge the content of these two subsections in section 2 as part of the revamping I'm doing in this PR: #1004.

@hannahhoward @dirkmc what's your take on this?

@dirkmc
Copy link
Contributor

dirkmc commented Jul 27, 2020

Agreed, that sounds like the right approach 👍

@yiannisbot
Copy link
Collaborator Author

The latest revision of section 2.5.2 (after the latest commit - #1004 (comment)) includes pretty much all the content from section 4.4, so the latter becomes obsolete. I suggest that we remove section 4.4 for now and if we later feel that we need reference of payment channels in section 4 we bring it back (with updated/new text).

@hannahhoward
Copy link
Contributor

yes I susport that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants