fix: sigma prime changes #1018
fix: sigma prime changes #1018
Conversation
There was a problem hiding this comment.
I can't say anything about the correctness (math wise), but there seem no accidental changes and it also renders fine.
When I was making the conversion to the spec I also found a few typos (as they did), sadly I can't find my notes about that anymore, but I remembered one one. On liine 862 (new file):
given a an encoding -> given an encoding
I don't know if it should be part of that PR or another one. Before merging, @DrPeterVanNostrand should give a thumbs up/down if he wants to fix that typo within this PR.
|
@vmx I would prefer to leave this PR as only the changes requested by sigma prime and leave spelling mistakes, which I'm sure there are many of, to a separate pr. |
|
@hugomrdias please merge, to me you're kind of the gatekeeper here and i don't want to destroy anything :) |
|
@hugomrdias Thanks! I'm tracking this and wanted to know if you know the final IPFS link for after the merge (for sharing with external parties). |
|
Just look for this commit you want and click the green check on the left. For this one its https://bafybeig5jbnrabcmyboisv2luzns6fpsm3mjrvucdk725bmvji3ilz72we.ipfs.dweb.link/ |
|
@cryptonemo I'd rather use https://bafybeidxw5vxjdwsun2zc2illagf43v6w5r5w63vg455h7vjesbyqssg64.ipfs.dweb.link/ (which is the commit on the branch and not the PR). |
|
Ok, thanks guys. @hugomrdias I had that one previously, but wanted the latest. I believe @vmx provided what I need |
This PR contains the spec changes that were requested by Sigma Prime during their proofs audit.