fix(content): chainsync section update #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schomatis
reviewed
Aug 31, 2020
It's a very helpful review! Addressed part of the comments and will follow up with the rest tomorrow to get this done. |
Thanks, I was actually referring to the fact we're killing 400 lines in this PR (which makes sense to me). |
schomatis
previously approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Talked this over with @yiannisbot in the sync, his comments SGTM.
…t/specs into chainsync-update
|
@hugomrdias please double-check all is ok and merge. |
hugomrdias
approved these changes
Sep 4, 2020
hugomrdias
changed the title
hugomrdias
added a commit
that referenced
this pull request
Sep 7, 2020
* master: (27 commits) fix(content): filecoin VM interface update (#1056) fix(content): chainsync section update (#1123) fix(content): libraries section update (#1115) fix: show hugo errors on build docs: tidy up the readme, add toc. (#1141) fix: reword stacked drg missing link text" fix: fix broken refs and change warns to errors (#1139) fix: import meter css (#1140) feat: build toc and dashboard in hugo (#1122) feat: show wip and reliable in progress bar (#1137) content: fix typo plus remove definition of weight (#1138) fix: css for label style and dashboard link (#1136) feat: add symbol embeds and listing (#1126) v1.0.1 feat(tooling): release scripts v1.0.0 chore: update readme and package.json fix: update dns link fix: fix broken links fix(content): FIL VM System Actors Update (#1061) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is updating the ChainSync section to match more closely the latest developments. Although nothing was terribly wrong in the previous version of the section, the text looked more like a rather theoretical specification. Furthermore, lots has changed in the way pubsub (i.e., GossipSub) works, which made the chainsync text look out of date.
We will try to keep a version of the previous text and link to it for those that will want to refer back to it.