fix: fix broken refs and change warns to errors #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomrdias
force-pushed
the
feat/errors
branch
from
eede3a9 to
b084602
Compare
olizilla
reviewed
Sep 3, 2020
| @@ -234,7 +234,7 @@ TODO: link to filproofs/feistel | |||
|
|
|||
| > The Replication phase turns an *unsealed sector* into a *sealed sector* by first *generating a key*, then using the key to *encode the orignal data*. | |||
|
|
|||
| Before running the `Replicate` algorithm, the prover must ensure that the sector is correctly formatted with a valid "Storage Format" described in [Filecoin Client Data Processing](/missing_link) (currently `paddedfr32v1` is the required default). | |||
| Before running the `Replicate` algorithm, the prover must ensure that the sector is correctly formatted with a valid "Storage Format" described in Filecoin Client Data Processing (currently `paddedfr32v1` is the required default). | |||
There was a problem hiding this comment.
If we have nothing to link to here, we should re-word it to not imply that there is
Suggested change
| Before running the `Replicate` algorithm, the prover must ensure that the sector is correctly formatted with a valid "Storage Format" described in Filecoin Client Data Processing (currently `paddedfr32v1` is the required default). | |
| Before running the `Replicate` algorithm, the prover must ensure that the sector is correctly formatted with a valid "Storage Format" (currently `paddedfr32v1` is the required default). |
There was a problem hiding this comment.
i will update this !
There was a problem hiding this comment.
after hugo: downloading modules ... ends 😱
hugomrdias
added a commit
that referenced
this pull request
Sep 7, 2020
* master: (27 commits) fix(content): filecoin VM interface update (#1056) fix(content): chainsync section update (#1123) fix(content): libraries section update (#1115) fix: show hugo errors on build docs: tidy up the readme, add toc. (#1141) fix: reword stacked drg missing link text" fix: fix broken refs and change warns to errors (#1139) fix: import meter css (#1140) feat: build toc and dashboard in hugo (#1122) feat: show wip and reliable in progress bar (#1137) content: fix typo plus remove definition of weight (#1138) fix: css for label style and dashboard link (#1136) feat: add symbol embeds and listing (#1126) v1.0.1 feat(tooling): release scripts v1.0.0 chore: update readme and package.json fix: update dns link fix: fix broken links fix(content): FIL VM System Actors Update (#1061) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #980
closes #1103