-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tooling): section menu, links, blockquotes and content boxes #1211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great set of improvements! Makes it look much better!
@hugomrdias the conflicting file (proof_of_spacetime_parameters.org) has now been removed by another PR that has just been merged. The edit to that file is minor (typo). I suggest just ignoring it from your commit to resolve the conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, didn't spot the issue that @olizilla brings up - it works very nicely in Chromiums with a horizontal slider One thing that seems a bit wonky is that the popup table/legend does not disappear when clicking elsewhere on the page or at another legend. The result can be that there are two overlapping ones. Minor thing, but would be nice to have fixed if it does not require a major amount of time. |
f63750f
to
8521066
Compare
This PR improves a couples of things
Depth slider css
Blockquotes now have proper background
Figures and embeds now have permalinks
Figures and embeds look the same
Embeds integrate all the elements inside same box as Figures
Section Menu
Now each section has a menu to aggregate all the info like state, audit, github edit link and unique identifier and more in the future like tests etc.
Check https://bafybeiexx7iex3upkzf76svkvvwhlg6xh6sxh5tq4k2t5hdvcjtsq63iuy.on.fleek.co/test/ to play with these new improved components.
Even faster CI without Go and fully on Fleek
Github action now only need node js and just run build and test scripts.
Other small stuff
closes #1173
closes #1202
closes #1157
closes #1185