Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooling): section menu, links, blockquotes and content boxes #1211

Merged
merged 8 commits into from
Oct 15, 2020

Conversation

hugomrdias
Copy link
Contributor

@hugomrdias hugomrdias commented Oct 14, 2020

This PR improves a couples of things

Depth slider css

Screenshot 2020-10-14 at 16 16 53

Screenshot 2020-10-14 at 16 17 32

Blockquotes now have proper background

Screenshot 2020-10-14 at 16 19 12

Figures and embeds now have permalinks

Screenshot 2020-10-14 at 16 19 57

Figures and embeds look the same

Screenshot 2020-10-14 at 16 21 42

Embeds integrate all the elements inside same box as Figures

Screenshot 2020-10-14 at 16 23 48

Section Menu

Now each section has a menu to aggregate all the info like state, audit, github edit link and unique identifier and more in the future like tests etc.

menu gif

Check https://bafybeiexx7iex3upkzf76svkvvwhlg6xh6sxh5tq4k2t5hdvcjtsq63iuy.on.fleek.co/test/ to play with these new improved components.

Even faster CI without Go and fully on Fleek

Github action now only need node js and just run build and test scripts.

Other small stuff

  • Remove multilang files
  • CSS tweaks
  • New system ui fonts
  • Better permalinks
  • All new svg icons, using svg symbols refs for perf

closes #1173
closes #1202
closes #1157
closes #1185

yiannisbot
yiannisbot previously approved these changes Oct 14, 2020
Copy link
Collaborator

@yiannisbot yiannisbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great set of improvements! Makes it look much better!

@yiannisbot
Copy link
Collaborator

@hugomrdias the conflicting file (proof_of_spacetime_parameters.org) has now been removed by another PR that has just been merged. The edit to that file is minor (typo). I suggest just ignoring it from your commit to resolve the conflict.

Copy link
Collaborator

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not had time to review the implementation, but the changes look beautiful!

The section heading menu is a neat idea. The icons could use a little more space and there is an overflow issue (in FF at least)

Screenshot 2020-10-14 at 21 42 19

@yiannisbot
Copy link
Collaborator

Ahh, didn't spot the issue that @olizilla brings up - it works very nicely in Chromiums with a horizontal slider

Screenshot 2020-10-14 at 23 51 37

One thing that seems a bit wonky is that the popup table/legend does not disappear when clicking elsewhere on the page or at another legend. The result can be that there are two overlapping ones. Minor thing, but would be nice to have fixed if it does not require a major amount of time.

Screenshot 2020-10-14 at 23 51 52

@hugomrdias hugomrdias changed the title feat: section menu, links, blockquotes and content boxes feat(tooling): section menu, links, blockquotes and content boxes Oct 15, 2020
@hugomrdias hugomrdias merged commit b3b926b into master Oct 15, 2020
@hugomrdias hugomrdias deleted the feat/section-menu branch October 15, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants