Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-filecoin mpool is broken #1071

Closed
whyrusleeping opened this issue Oct 5, 2018 · 3 comments
Closed

go-filecoin mpool is broken #1071

whyrusleeping opened this issue Oct 5, 2018 · 3 comments

Comments

@whyrusleeping
Copy link
Member

Misleading title, the command reliably works for the only thing we ever use it for, checking the number of messages in the mempool. But the hashes that it spits out are not actually the hashes of messages in the mempool (actually, they should be all the same hash).

The problem is that 'View' returns []SignedMessages, and the commands 'type' is an array of Message (not signed). This causes unmarshaling to not work right. We get the right number of items, but each of the items is empty because the data coming over the wire has no fields in common with the expected type.

This could probably be prevented by a check in the commands lib, cc @Stebalien

@whyrusleeping
Copy link
Member Author

Note: I patched this in #1064. A better 'fix' would include a check that the types we emit are always what we expect

@Stebalien
Copy link
Member

Related to ipfs/go-ipfs-cmds#120

@anorth
Copy link
Member

anorth commented Jul 22, 2019

I think this is fixed now, mpool and commands were rewritten and we haven't seen any reports of this for ages.

@anorth anorth closed this as completed Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants