Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] CLI最佳实践优化？ #5298

Closed
1 task
Fatman13 opened this issue Sep 16, 2022 · 1 comment
Closed
1 task

[chore] CLI最佳实践优化？ #5298

Fatman13 opened this issue Sep 16, 2022 · 1 comment
Labels
C-dev-productivity Category: Developer productivity P3 Low - not important right now

Comments

@Fatman13
Copy link
Collaborator

Fatman13 commented Sep 16, 2022 •
edited
Loading

CLI最佳实践优化？help文字，IsError()，NArg()等等；

关联：
@Fatman13 Fatman13 added C-dev-productivity Category: Developer productivity C-triage Category: Need triage labels Sep 16, 2022
@zl03jsj
Copy link
Contributor

zl03jsj commented Sep 16, 2022 •
edited
Loading

需要, 但优先级不高.

在实施过程中, 需要考虑以下因素:

由于venus的包含较多组件, 对于一些公共的封装如:
https://github.com/filecoin-project/lotus/blob/4f75e2041c13cdd8be8bdcd790449c2ec7f0091f/cli/helper.go#L34

可以考虑放到公共的库中, 供各个组件引用.

@zl03jsj zl03jsj added P3 Low - not important right now and removed C-triage Category: Need triage labels Sep 16, 2022
@zl03jsj zl03jsj removed their assignment Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-dev-productivity Category: Developer productivity P3 Low - not important right now
Projects
Venus Project
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Fatman13 @zl03jsj @hunjixin