Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename "sector store type" to "proofs mode" #2534

Merged
merged 5 commits into from
Apr 10, 2019
Merged

rename "sector store type" to "proofs mode" #2534

merged 5 commits into from
Apr 10, 2019

Conversation

laser
Copy link
Contributor

@laser laser commented Apr 9, 2019 •
edited
Loading

Makes incremental progress towards #2530.

What's in this PR?

  • rename "SectorStoreType" to "ProofsMode"

Why is this PR needed?

  • the old name didn't make sense

@laser laser force-pushed the feat/2530-rename-to-proofs-mode branch 2 times, most recently from 6bd003b to d1c4564 Compare April 9, 2019 21:58
@laser laser changed the title [WIP - DO NOT MERGE] rename "sector store type" to "proofs mode" Apr 9, 2019
@laser laser requested a review from ZenGround0 April 9, 2019 22:00
@laser
Copy link
Contributor Author

laser commented Apr 9, 2019

cc @rkowalick

@laser laser requested a review from lkowalick April 9, 2019 22:00
ZenGround0
ZenGround0 approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

proofs/interface.go Show resolved Hide resolved
@lkowalick
Copy link
Contributor

As per the quote below, can you rename proofs.Test and proofs.Live?

Could I convince you to use the term "proofs mode" and type proofs.Mode instead of "sector store type" (proofs.SectorStoreType) in your PR?

The two members of that type would be LiveMode and TestMode.

@laser laser force-pushed the feat/2530-rename-to-proofs-mode branch from d1c4564 to 4e0ae3e Compare April 10, 2019 22:10
@laser laser force-pushed the feat/2530-rename-to-proofs-mode branch from 4e0ae3e to 72015a3 Compare April 10, 2019 22:37
@laser
Copy link
Contributor Author

laser commented Apr 10, 2019

@rkowalick -

As per the quote below, can you rename proofs.Test and proofs.Live?

done!

@laser laser merged commit 79bba96 into master Apr 10, 2019
@laser laser deleted the feat/2530-rename-to-proofs-mode branch May 1, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZenGround0 ZenGround0 ZenGround0 approved these changes

@lkowalick lkowalick Awaiting requested review from lkowalick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laser @lkowalick @ZenGround0