[part 3] "miner create" command must accept "sectorsize" flag #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laser
changed the base branch from
master
to
feat/2530-create-miner-with-sector-size
laser
changed the title
laser
changed the title
laser
force-pushed
the
feat/2530-command-for-create-miner-accepts-size
branch
2 times, most recently
from
b8bdf0a to
214577a
Compare
laser
requested review from
anorth,
acruikshank and
ZenGround0
and removed request for
acruikshank
anorth
approved these changes
Jun 4, 2019
| @@ -50,10 +51,11 @@ miner's collateral drops below 0.001FIL, the miner will not be able to commit | |||
| additional sectors.`, | |||
| }, | |||
| Arguments: []cmdkit.Argument{ | |||
| cmdkit.StringArg("collateral", true, false, "The amount of collateral, in FIL"), | |||
| cmdkit.StringArg("collateral", true, false, "The amount of collateral, in FIL."), | |||
There was a problem hiding this comment.
FWIW I think we could make this an option (rather than argument) too
laser
force-pushed
the
feat/2530-create-miner-with-sector-size
branch
from
37062e9 to
8088123
Compare
laser
changed the base branch from
feat/2530-create-miner-with-sector-size
to
master
laser
force-pushed
the
feat/2530-command-for-create-miner-accepts-size
branch
from
214577a to
ee18338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2530.
Note that this PR is based off of #2873. Once that PR is merged, this PR will need to be rebased onto
master.Why does this PR exist?
We need to give an operator a command option which lets them pick the size of the sectors which their newly-created storage miner actor will commit.
What's in this PR?
miner createto accept an optionalsectorsizeflagUsage
Invalid
sectorsizeUnsupported
sectorsize