Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a timeout option to "message wait" command #2881

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Add a timeout option to "message wait" command #2881

merged 2 commits into from
Jun 5, 2019

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Jun 3, 2019

Summary

Add a timeout argument to message wait that accepts duration strings compatible with time.ParseDuration.

Resolves #1552

anorth
anorth approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to include a maintainer for review. Committers usually do this up-front to reduce the expected latency, although inviting just a single reviewer first is appropriate if you're not very sure about the change.

commands/message.go Outdated Show resolved Hide resolved
@ingar ingar force-pushed the feat/add-timeout-to-message-wait-command-1552 branch from a367ecb to d9e623c Compare June 5, 2019 17:51
@ingar ingar merged commit 49d4767 into master Jun 5, 2019
frrist pushed a commit that referenced this pull request Jun 6, 2019
@ingar @frrist
Add a timeout option to "message wait" command (#2881)
90b6b75 
- defaults to 10 minutes
@ingar ingar deleted the feat/add-timeout-to-message-wait-command-1552 branch June 20, 2019 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frrist frrist frrist approved these changes

@anorth anorth anorth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the message wait command should accept a timeout
3 participants
@ingar @anorth @frrist