Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timestamp field to block struct #2895

Closed
wants to merge 3 commits into from

Conversation

frrist
Copy link
Member

@frrist frrist commented Jun 5, 2019

What

This PR adds a timestamp to block, currently these timestamps are set to 0. This will be updated to use the BlockClock interface defined in #2894 once it merges. These updates will be made while completing #2886.

@codecov-io
Copy link

codecov-io commented Jun 5, 2019

Codecov Report

Merging #2895 into feat/miner-worker-clock will increase coverage by <1%.
The diff coverage is 40%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feat/miner-worker-clock   #2895    +/-   ##
========================================================
+ Coverage                       43%     43%   +<1%     
========================================================
  Files                          208     208            
  Lines                        12399   12411    +12     
========================================================
+ Hits                          5371    5389    +18     
+ Misses                        6217    6212     -5     
+ Partials                       811     810     -1
Impacted Files Coverage Δ
types/block.go 82% <ø> (ø) ⬆️
commands/message.go 0% <0%> (ø) ⬆️
mining/block_generate.go 71% <100%> (ø) ⬆️
gengen/util/gengen.go 49% <100%> (ø) ⬆️
protocol/storage/miner.go 23% <0%> (ø) ⬆️
mining/worker.go 54% <0%> (ø) ⬆️
consensus/block_validation.go 0% <0%> (ø) ⬆️
protocol/storage/client.go 49% <0%> (ø) ⬆️
node/node.go 59% <0%> (ø) ⬆️
protocol/hello/hello.go 86% <0%> (+9%) ⬆️

@frrist frrist force-pushed the feat/block-timestamp branch from 7c772f8 to e04275a Compare June 5, 2019 22:59
@frrist frrist mentioned this pull request Jun 6, 2019
1 task
@frrist frrist changed the base branch from master to feat/miner-worker-clock June 6, 2019 14:25
@frrist frrist force-pushed the feat/block-timestamp branch from 369223c to 90b6b75 Compare June 6, 2019 14:26
@frrist frrist closed this Jun 6, 2019
@zl03jsj zl03jsj deleted the feat/block-timestamp branch July 14, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants