Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/transform.js determining wrong is_folder, is_file values #1

Open
BrianSo opened this issue Jan 4, 2015 · 1 comment
Open

lib/transform.js determining wrong is_folder, is_file values #1

BrianSo opened this issue Jan 4, 2015 · 1 comment

Comments

@BrianSo
Copy link

BrianSo commented Jan 4, 2015

In lib/transform.js,
At line 124, it uses current_item.type != "folder" to determine whether it is a folder.
But one drive may return a folder with type='album', which makes the program treat that the folder is a file.

I found that one drive always return identifier like this folder.e0de0104ecb2448c.E0DE0104ECB2448C!107.
It means we can use identifier to determine whether it is a folder.

Problems exist on line 62,63,105,106,124 also.

@AnalogJ
Copy link
Member

AnalogJ commented Jan 4, 2015

Ahh good catch, I don't use those special folder types so I never noticed. If you want to create a PR I can merge it in, or I should have time to make this fix sometime this week.

AnalogJ added a commit that referenced this issue Jun 12, 2015
OneDrive API no longer provides email and modification date, and fixes for #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants