-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Alignment Issue in Properties - "Type" and "File System" Misalignment #12727
Comments
Thanks for the report, I've added this to the project board. |
Hey there, I'd love to work on this issue. But since I'm a beginner it'd be of great help if you could point me from where I can start? Thanks! |
I would start at Files/src/Files.App/ResourceDictionaries/PropertiesStyles.xaml Lines 21 to 27 in d97f3e1
and remove the lines: 21, 24, 40 |
Hello @Jay-o-Way, thanks a lot for the detailed help, but I apologize I wouldn't be able to work on this issue right now. Although I'd love to tackle it in the near future :D |
@ItIsOHM Okay. It's a quick fix, but if you really want to do it, then I will not take it from you, for now. |
Ah thanks! Then i'll try to fix it in some days if it's alright? In the meantime if anyone else would like to work on this then they can :D |
Can we also use the Secondary or Tertiary text brushes to distinguish the heading text, from the value text? Similar to what @yaira2 recently did with the Details pane |
I ended up doing this together with some other tweaks to the properties window, let me know if you'd like me to recommend another issue. |
Description
I have noticed an alignment issue in the properties window when performing a right-click on a file, folder, drive, or other items and accessing the properties. Specifically, the "Type:" label is misaligned with the corresponding element, and the "File System:" label is misaligned with the actual file system information of the drive, both appearing slightly shifted compared to the rest of the categories in the properties.
Steps To Reproduce
Requirements
Adjust the layout and formatting of the properties window to ensure proper alignment of the "Type" and "File System" labels with their respective elements.
Files Version
Version 2.5.2.0 / dev
Windows Version
22H2 22621.1848
Log File
What propreties displays:
![Capture d'écran 2023-06-25 100128](https://private-user-images.githubusercontent.com/128183422/248539781-dcbb2333-d70d-4674-8225-0780d26394ab.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MDY0NTcsIm5iZiI6MTczOTUwNjE1NywicGF0aCI6Ii8xMjgxODM0MjIvMjQ4NTM5NzgxLWRjYmIyMzMzLWQ3MGQtNDY3NC04MjI1LTA3ODBkMjYzOTRhYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQwNDA5MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zMmJjZjY0ZDk0MTMyNTIwYTFkYzMyMWUyNzEwYjlmODJhMjA3NWFmYjg1MjU1YmZjNTYxY2UyZmI0OWM1Mjc2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.e7LtDJzI7wiYYtzl3zs0g9e5SKvpVugAo3lEbTnOKBs)
![Capture d'écran 2023-06-25 100352](https://private-user-images.githubusercontent.com/128183422/248539784-0b009871-a1c8-4980-a127-25835d46ebef.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MDY0NTcsIm5iZiI6MTczOTUwNjE1NywicGF0aCI6Ii8xMjgxODM0MjIvMjQ4NTM5Nzg0LTBiMDA5ODcxLWExYzgtNDk4MC1hMTI3LTI1ODM1ZDQ2ZWJlZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQwNDA5MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hMjE1YmRiNGRiN2ZmMjcwODJiMThiMmNjMmY4MjI3MjExMGE4MDMyNDc1N2IxMTE2OWY3MTUzYTQyNzJlNzc3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.RwcwGXGOxiK9uCrmL6lao-NLCQgdsNjBPPNoD6mWUEg)
![Capture d'écran 2023-06-25 100546](https://private-user-images.githubusercontent.com/128183422/248539862-ee657b6a-0227-4b5b-80b9-db99dabceef6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MDY0NTcsIm5iZiI6MTczOTUwNjE1NywicGF0aCI6Ii8xMjgxODM0MjIvMjQ4NTM5ODYyLWVlNjU3YjZhLTAyMjctNGI1Yi04MGI5LWRiOTlkYWJjZWVmNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQwNDA5MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02N2Y2ZjVlMGE3MTMzMWU4NWVhMzI1NDA2OGU3MGVhOWU1NGM0ODY5Y2YyMWJiZjNjMWQzYjgyOTJiODIyODZjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.X9EyobhUxIqDE3t15-rBcqv-UutzRhaZPLZl0qdUIIM)
How it should be displayed
The text was updated successfully, but these errors were encountered: