Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Alignment Issue in Properties - "Type" and "File System" Misalignment #12727

Closed
Lukiluc29 opened this issue Jun 25, 2023 · 8 comments · Fixed by #12795
Closed

Bug: Alignment Issue in Properties - "Type" and "File System" Misalignment #12727

Lukiluc29 opened this issue Jun 25, 2023 · 8 comments · Fixed by #12795
Assignees
Labels
good first issue Good issue for new contributors to get started with

Comments

@Lukiluc29
Copy link
Contributor

Description

I have noticed an alignment issue in the properties window when performing a right-click on a file, folder, drive, or other items and accessing the properties. Specifically, the "Type:" label is misaligned with the corresponding element, and the "File System:" label is misaligned with the actual file system information of the drive, both appearing slightly shifted compared to the rest of the categories in the properties.

Steps To Reproduce

  1. Open Files
  2. Right-click on a file
  3. Click on propreties

Requirements

Adjust the layout and formatting of the properties window to ensure proper alignment of the "Type" and "File System" labels with their respective elements.

Files Version

Version 2.5.2.0 / dev

Windows Version

22H2 22621.1848

Log File

What propreties displays:
Capture d'écran 2023-06-25 100128
Capture d'écran 2023-06-25 100352
How it should be displayed
Capture d'écran 2023-06-25 100546

@Lukiluc29 Lukiluc29 added the bug label Jun 25, 2023
@Josh65-2201
Copy link
Member

Thanks for the report, I've added this to the project board.

@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Jun 26, 2023
@yaira2 yaira2 added the good first issue Good issue for new contributors to get started with label Jun 26, 2023
@ItIsOHM
Copy link

ItIsOHM commented Jun 27, 2023

Hey there, I'd love to work on this issue. But since I'm a beginner it'd be of great help if you could point me from where I can start? Thanks!

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Jun 29, 2023

I would start at

<Thickness x:Key="PropertyNameMargin">0,4</Thickness>
<Style x:Key="PropertyName" TargetType="TextBlock">
<Setter Property="Margin" Value="{StaticResource PropertyNameMargin}" />
<Setter Property="FontSize" Value="14" />
<Setter Property="FontWeight" Value="SemiBold" />
</Style>

and remove the lines: 21, 24, 40

@ItIsOHM
Copy link

ItIsOHM commented Jun 29, 2023

Hello @Jay-o-Way, thanks a lot for the detailed help, but I apologize I wouldn't be able to work on this issue right now. Although I'd love to tackle it in the near future :D

@Jay-o-Way
Copy link
Contributor

@ItIsOHM Okay. It's a quick fix, but if you really want to do it, then I will not take it from you, for now.

@ItIsOHM
Copy link

ItIsOHM commented Jun 29, 2023

@ItIsOHM Okay. It's a quick fix, but if you really want to do it, then I will not take it from you, for now.

Ah thanks! Then i'll try to fix it in some days if it's alright? In the meantime if anyone else would like to work on this then they can :D

@mdtauk
Copy link
Contributor

mdtauk commented Jun 29, 2023

Can we also use the Secondary or Tertiary text brushes to distinguish the heading text, from the value text?

Similar to what @yaira2 recently did with the Details pane

@yaira2 yaira2 self-assigned this Jun 29, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Ready to build to ✅ Done in Files task board Jun 29, 2023
@yaira2
Copy link
Member

yaira2 commented Jun 29, 2023

Hey there, I'd love to work on this issue. But since I'm a beginner it'd be of great help if you could point me from where I can start? Thanks!

I ended up doing this together with some other tweaks to the properties window, let me know if you'd like me to recommend another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for new contributors to get started with
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants