Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Modal for disabled drag'n'drop in Admin Mode #13209

Closed
QuaintMako opened this issue Aug 17, 2023 · 9 comments · Fixed by #13221
Closed

Feature: Modal for disabled drag'n'drop in Admin Mode #13209

QuaintMako opened this issue Aug 17, 2023 · 9 comments · Fixed by #13221
Assignees

Comments

@QuaintMako
Copy link
Contributor

What feature or improvement do you think would benefit Files?

#13134 disabled several instance of drag and drop through the app to prevent a crash when running admin mode. (See #12390)

Regardless, there is no way for the user to see it's an intended behavior. A modal should be displayed when the user tries to drag and drop in those situations, with a don't show again checkbox.

The disable situations are:

  • Drag and drop in the main view
  • Drag and drop in the tag edition settings tab
  • Drag and drop to reorder favorites

Requirements

  • This proposal will enhance the user experience by providing feedback.

Files Version

2.5.22

Windows Version

10.0.19045.3324

Comments

No response

@yaira2 yaira2 changed the title Feature Request: Modal for disabled drag'n'drop in Admin Mode Feature: Modal for disabled drag'n'drop in Admin Mode Aug 17, 2023
@yaira2
Copy link
Member

yaira2 commented Aug 17, 2023

Thanks for the issue. I think it'll be less of a problem now that we support admin operations without elevating the main process, but this is still something we should address.

@hishitetsu
Copy link
Member

How about displaying a modal when the app is launched, rather than when the user tries to drag and drop?
There is another limitation that the file selection dialog cannot be opened when running as Administrator and it would be more helpful to tell the user all the restrictions at startup.

@yaira2
Copy link
Member

yaira2 commented Aug 17, 2023

How about displaying a modal when the app is launched, rather than when the user tries to drag and drop?

It's usually better to associate it directly with the action, a lot of users tend to skim through prompts and won't pay attention to what it says if it's displayed on startup.

There is another limitation that the file selection dialog cannot be opened when running as Administrator and it would be more helpful to tell the user all the restrictions at startup.

I think there are some workarounds for the file selection dialog.

@hishitetsu
Copy link
Member

It's usually better to associate it directly with the action, a lot of users tend to skim through prompts and won't nearly pay attention to what it says if it's displayed on startup.

Maybe so, but wouldn't it still be better to tell the user that they can perform admin operations without running the app as admin at startup so that the user can quickly see a better solution?

@yaira2
Copy link
Member

yaira2 commented Aug 17, 2023

We can do that as well 👍

@yaira2
Copy link
Member

yaira2 commented Aug 18, 2023

Drag and drop in the tag edition settings tab

I'm not sure we can do this one because you can only display one content dialog at a given time.

@QuaintMako
Copy link
Contributor Author

Drag and drop in the tag edition settings tab

I'm not sure we can do this one because you can only display one content dialog at a given time.

Good side of getting dialog only at start then eliminates the need to get it to pop-up at the point.

@yaira2 yaira2 self-assigned this Aug 18, 2023
@yaira2
Copy link
Member

yaira2 commented Aug 20, 2023

I'll work on this

@yaira2
Copy link
Member

yaira2 commented Aug 20, 2023

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants