Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid syntax of github action file #90

Merged
merged 7 commits into from
Dec 17, 2021
Merged

Fix invalid syntax of github action file #90

merged 7 commits into from
Dec 17, 2021

Conversation

errnesto
Copy link
Collaborator

@errnesto errnesto commented Nov 23, 2021

Okay I'm very sorry for my messy contributions :-( The github action is still broken.
I'm trying to clean it up here.

The last time. I tested the action locally with https://github.com/nektos/act where it worked fine, but the syntax for the action was still invalid.

By now I don't know if there is a good way to do this with only an action file.
So I created a entrypoint.sh file and another Dockerfile.
There it is easier to access the input variables from github.

And I added a "test" here:
https://github.com/wunderundfitzig/linkcheck-action/runs/4301401999?check_suite_focus=true

@andrenarchy
Copy link

It would be great to see this merged and in a new release as soon as possible because the action is not usable for us currently.

@errnesto
Copy link
Collaborator Author

@filiph ping :-)
I’m also happy to apply some changes to this. e.g. if you would prefer to use just one Dockerfile. Then the entrypoint.sh would just go unused in the normal case.

@filiph
Copy link
Owner

filiph commented Dec 17, 2021

Thanks for the ping! To be honest, I don't know enough about Docker to review this. I hoped I'd have time by now to learn more, but I don't. I'll just merge it. Please let me know if there's anything else I need to do.

@filiph filiph merged commit 1234fe0 into filiph:master Dec 17, 2021
@tooomm
Copy link
Contributor

tooomm commented Apr 28, 2022

@filiph Since your published action is sadly still not working in the GitHub Marketplace... do you mind trying to publish a new release targeting master?
All changes in recent months (like this one) that were targeted at fixing the GH Action are not yet in a published release.
It looks like you published the current version in February 2022, but targeted 2.0.20 from October 2021 (69913d9). Therefore the change in this PR is not included and distributed yet.

I created #95 and drafted a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants