-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce asset endpoints #1017
Conversation
8792806
to
a4e8426
Compare
Codecov Report
@@ Coverage Diff @@
## master #1017 +/- ##
==========================================
+ Coverage 84.28% 84.83% +0.54%
==========================================
Files 48 49 +1
Lines 910 956 +46
Branches 57 67 +10
==========================================
+ Hits 767 811 +44
- Misses 143 145 +2
Continue to review full report at Codecov.
|
I like this. For the name, maybe My only other thought is maybe we should replace the example of serving static files in the cookbook with this. |
Yes, I need to update the cookbook. Also I like your |
a4e8426
to
a50ad4d
Compare
Turns out after we deprecated Twitter Futures in the mapper it became problematic to serve static files (although people generally not supposed to do that) with
Reader
s.This PR leverages cats-effect
Resource
to read Java resources and serve them as a static content.An example: