Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headerNotParse function to Rs #930

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

jsancio
Copy link
Contributor

@jsancio jsancio commented Mar 23, 2018

ran sbt -J-XX:MaxMetaspaceSize=1G test.

@jsancio
Copy link
Contributor Author

jsancio commented Mar 23, 2018

Resolves #929 .

@codecov-io
Copy link

codecov-io commented Mar 23, 2018

Codecov Report

Merging #930 into master will decrease coverage by 0.62%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
- Coverage   82.81%   82.18%   -0.63%     
==========================================
  Files          51       51              
  Lines         768      769       +1     
  Branches       39       34       -5     
==========================================
- Hits          636      632       -4     
- Misses        132      137       +5
Impacted Files Coverage Δ
core/src/main/scala/io/finch/endpoint/header.scala 62.5% <100%> (ø) ⬆️
core/src/main/scala/io/finch/internal/Rs.scala 100% <100%> (ø) ⬆️
core/src/main/scala/io/finch/Input.scala 87.5% <0%> (-12.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a02e2c...048c123. Read the comment docs.

@vkostyukov
Copy link
Collaborator

Nice @jsancio! I will release 0.18.1 shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants