From 93c440d773af67a43670dc9667604e11a36fc3f6 Mon Sep 17 00:00:00 2001 From: Marius Grama Date: Tue, 28 Jun 2022 17:03:50 +0200 Subject: [PATCH] Exclude test from TestDeltaLakeDropTableCompatibility class Avoid running into a test failure when dealing with a test depending on Databricks AWS S3 and AWS Glue environment. Consult for further details: https://github.com/trinodb/trino/issues/13017 --- .../TestDeltaLakeDropTableCompatibility.java | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/testing/trino-product-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeDropTableCompatibility.java b/testing/trino-product-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeDropTableCompatibility.java index ca2435cf443c..1204e1f46283 100644 --- a/testing/trino-product-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeDropTableCompatibility.java +++ b/testing/trino-product-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeDropTableCompatibility.java @@ -60,14 +60,25 @@ public static Object[][] engineConfigurations() {TRINO, DELTA, true}, {TRINO, DELTA, false}, {DELTA, TRINO, true}, - {DELTA, TRINO, false}, {DELTA, DELTA, true}, {DELTA, DELTA, false}, }; } @Test(groups = {DELTA_LAKE_DATABRICKS, DELTA_LAKE_OSS, PROFILE_SPECIFIC_TESTS}, dataProvider = "engineConfigurations") - public void testDatabricksManagedTableDroppedFromTrino(Engine creator, Engine dropper, boolean explicitLocation) + public void testDropTable(Engine creator, Engine dropper, boolean explicitLocation) + { + testDropTableAccuracy(creator, dropper, explicitLocation); + } + + @Test(groups = {DELTA_LAKE_DATABRICKS, DELTA_LAKE_OSS, PROFILE_SPECIFIC_TESTS}) + public void testCreateManagedTableInDeltaDropTableInTrino() + { + //TODO Integrate this method into `engineConfigurations()` data provider method after dealing with https://github.com/trinodb/trino/issues/13017 + testDropTableAccuracy(DELTA, TRINO, false); + } + + private void testDropTableAccuracy(Engine creator, Engine dropper, boolean explicitLocation) { String schemaName = "schema_with_location_" + randomTableSuffix(); String schemaLocation = format("s3://%s/databricks-compatibility-test-%s", bucketName, schemaName);