Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aloituskuulutuksen hyvaksynta (HASSU-187) #134

Merged
merged 6 commits into from
Mar 1, 2022

Conversation

kettunju
Copy link
Contributor

No description provided.

@kettunju kettunju requested a review from tkork February 25, 2022 14:23
Comment on lines +1 to +4
import { Dialog } from "@mui/material";
import React, { ReactElement } from "react";

const HassuDialog = (props: any): ReactElement => {
Copy link
Contributor

@tkork tkork Mar 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kannattaisiko käyttää MUI DialogProps-tyyppiä propseissa?

Suggested change
import { Dialog } from "@mui/material";
import React, { ReactElement } from "react";
const HassuDialog = (props: any): ReactElement => {
import { Dialog, DialogProps } from "@mui/material";
import React, { ReactElement } from "react";
const HassuDialog = (props: DialogProps): ReactElement => {

@kettunju kettunju merged commit 9ae73da into main Mar 1, 2022
@kettunju kettunju deleted the feature/HASSU-187-aloituskuulutuksen-hyvaksynta branch March 1, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants