feat: HASSU-740 nahtävillaolo sisällonkuvaus ja yhteystiedot #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 10, 2022 15:31
…a nähtävilläolovaiheen lomaketta.
tkork
reviewed
Jun 13, 2022
| export const nahtavillaoloKuulutusSchema = Yup.object().shape({ | ||
| oid: Yup.string().required(), | ||
| nahtavillaoloVaihe: Yup.object() | ||
| .required() | ||
| .shape({ | ||
| kuulutusYhteystiedot: Yup.array().notRequired().of(yhteystietoSchema), | ||
| kuulutusYhteysHenkilot: Yup.array().notRequired().of(Yup.string()), | ||
| hankkeenKuvaus: Yup.object().shape({ SUOMI: hankkeenKuvaus }), |
There was a problem hiding this comment.
Eikös tässä olla tarkistuksia myös muille kielille?
There was a problem hiding this comment.
Ei ole muissakaan schemoissa. Kai se on se, kun ne ovat vapaaehtoisia
There was a problem hiding this comment.
Eiks ne oo konditionaalisisesti vaadittuja? Silloin kun on se toinen kieli niin silloin se hankkeenkuvaus on annettava silläkin kielellä. Mut mun puolest voi mennä tällä erää näin
added 2 commits
June 13, 2022 15:04
tkork
approved these changes
Jun 13, 2022
ValheKouneli
deleted the
feature/HASSU-740-nahtavillaolo-sisallonkuvaus-ja-yhteystiedot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.