Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hassu 891 hassu 892 aineistojen UI #337

Merged
merged 7 commits into from
Aug 26, 2022

Conversation

ValheKouneli
Copy link
Contributor

No description provided.

@tkork tkork self-requested a review August 25, 2022 13:32
Copy link
Contributor

@tkork tkork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Menee kuvien mukaisella tavalla 👍. Kälikuvissa on tehty muutoksia nähtävilläolovaiheen aineistohaitareihin ja niihin voi ilmeisesti vielä tulla muutoksia, mutta niistä voisi tehdä tiketit kunhan Jade on saanut ne viimeisteltyä ja ne on "lyöty lukkoon".

import {
AineistoKategoria,
aineistoKategoriat,
kategorianAllaOlevienAineistojenMaara,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turha importti?

Comment on lines 169 to 173
),
};
}),
[t, julkaisu, kategoriat]
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tohon dependency arrayhin pitää lisätä viel paakategoria, eikös?

Copy link
Contributor

@tkork tkork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noi kaks linttauksessa havaittua ongelmaa vois fiksaa

@ValheKouneli ValheKouneli merged commit b77e46a into main Aug 26, 2022
@ValheKouneli ValheKouneli deleted the fix/HASSU-891_HASSU-892_aineistojen-ui branch August 26, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants