feat: Tarkemman ELY-organisaatiotiedon syöttäminen ja näyttäminen #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on annettu käyttäjälle
kettunju
reviewed
Feb 10, 2023
| return this.props.yhteystiedot.map((y) => { | ||
| let organisaatio = y.kunta ? kuntametadata.nameForKuntaId(y.kunta, this.kieli) : y.organisaatio; | ||
| if (y.kunta) { | ||
| organisaatio = kuntametadata.nameForKuntaId(y.kunta, this.kieli); |
There was a problem hiding this comment.
etkö tuossa yllä jo tehnyt tämän
kettunju
reviewed
Feb 10, 2023
| await validateTallennaProjekti(projekti, input); | ||
| }); | ||
|
|
||
| it("elyOrganisaatio tiedon ei voi tallettaa kayttajalle, jolla organisaatio on asetettu 'ELY':ksi", async () => { |
There was a problem hiding this comment.
testin kuvaus vähän pielessä
kettunju
reviewed
Feb 10, 2023
| @@ -151,6 +153,7 @@ function AloituskuulutusForm({ projekti, projektiLoadError, reloadProjekti }: Al | |||
| return tallentamisTiedot; | |||
| }, [projekti]); | |||
|
|
|||
| console.log("käännös ", translate("viranomainen." + ELY.ETELA_POHJANMAAN_ELY, Kieli.SUOMI)); | |||
There was a problem hiding this comment.
voinee poistaa kun valmis
kettunju
approved these changes
Feb 10, 2023
|
Hyviä huomioita korjaan noi |
added 2 commits
February 13, 2023 09:37
…us, ylimääräinen organisaatiokäsittely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Muokkasin tässä lisäksi:
Itse toteutus koostuu: