Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Tools Menu should open in a dedicated window #44

Closed
nkolba opened this issue Jun 14, 2022 · 2 comments
Closed

Dev Tools Menu should open in a dedicated window #44

nkolba opened this issue Jun 14, 2022 · 2 comments

Comments

@nkolba
Copy link
Contributor

nkolba commented Jun 14, 2022

As per issue #43... Currently, if the main window size is too small, the '...' menu for dev tools wraps so that the menu items become obscured. This happens because the toolbar is being rendered in a window that is truncated by the browser view for rendering the tab content. The current menu for devtools is rendered in the DOM of the toolbar window - so if there isn't enough space - it just gets cutoff.

The solution is to use the same method for rendering this menu as is used for the color picker menu, search results, etc, which is to render as a dedicated window that can overlay the content of the main window and is not bound by it's DOM.

@nkolba
Copy link
Contributor Author

nkolba commented Jun 14, 2022

Actually, taking another look, this should be resolvable with the Electron menu apis https://www.electronjs.org/docs/latest/api/menu

@nkolba
Copy link
Contributor Author

nkolba commented Jun 14, 2022

addressed with PR #45

@nkolba nkolba closed this as completed Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant