-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: IntentResolution.data property not supported by addIntentListener callback #127
Comments
IntentResolution.data
property not supported by addIntentListener
callback
my vote would be for #3 - Amend the addIntentListener interface to include a way to pass data back to the caller. |
I would like to propose that we leave the discrepancy with the data property, and the concept of returning results from intents alone for the 1.2 release. There is a lot going into the 1.2 release already, and I feel like we need to tackle this topic properly subsequent to the 1.2 release. Things to consider are:
|
Close in favour of #201 |
The
IntentResolution
type returned byraiseIntent
is defined as follows:but the
addIntentListener
callback is defined as follows:which includes no way to return data back to the caller. It is therefore impossible to populate the data property with the 1.0 API, causing an API inconsistency.
There are three options:
data
property from theIntentResolution
interface until it can be provided.addIntentListener
interface to include a way to pass data back to the caller.The text was updated successfully, but these errors were encountered: