Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDC3 for Web Browsers Discussion group 17th October 2024 #1391

Closed
11 tasks done
kriswest opened this issue Oct 16, 2024 · 9 comments
Closed
11 tasks done

FDC3 for Web Browsers Discussion group 17th October 2024 #1391

kriswest opened this issue Oct 16, 2024 · 9 comments
Labels
help wanted Extra attention is needed meeting

Comments

@kriswest
Copy link
Contributor

kriswest commented Oct 16, 2024

Group overview

Group convened to work on proposals to enable FDC3 use in a web browser, without the use of a browser extension.

Pull requests:

Relevant issue tags

Current open issues that relate to the above concepts with the label:
image

Meeting Date

Thursday 17th Oct 2024 - 11am (US eastern timezone EDT) / 4pm (London, BST)

Zoom info

  • Join Zoom Meeting
  • Meeting ID: 969 4029 4948
  • Passcode: 636931
  • Dial-in:
    Country International Dial-in Toll-free Dial-in
    US +1 929 205 6099 (New York) 877 853 5247
    UK +44 330 088 5830 0800 031 5717
    France +33 1 8699 5831 0 800 940 415
    Find your local number https://zoom.us/u/ad2WVnBzb8

Meeting notices

  • FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

  • All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

  • FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact legal@finos.org with any questions.

  • FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

  • A Discussion Group has no direct decision-making power regarding the FDC3 standard - rather it is intended that anything they propose or work on will result in proposals (via Github issues and PRs) for the Standards Working Group participants to consider and vote on for inclusion in the standard.

Participation Requirements

Note: Meeting participants are expected to accept the terms of the FDC3 license (Community Specification License), understand the governance process and have a CLA in place.

Please click the following links at the start of the meeting if you have not done so previously.

Tracking Attendance

Note: Meeting participants are expected to add a comment to this GitHub issue in order that we can track attendance of FDC3 project meetings. Please do this at the start of the meeting.

Agenda

Minutes

  • Update on current status of release & discussion of how to get involved
    • Received consent from standards working group, PR is out to maintainers to sign off.
      • Before we can release 2.2, the software PR also has to be accepted by the community.
      • Rob Moffat has worked on an implementation, and tests showing that it is conformant as far as the messages are concerned and that produces a conformant Desktop Agent
        • This includes the getAgent() method, which is the new recommended way to retrieve a DA implementation
      • Request a review meeting with Rob, to help introduce people to the changes in the PR (which has 500+ files changed). It is imperative that we get more involvement into the review and the code.
  • window.fdc3 should be marked as optional #1385
    • Kris is supportive, and the change is small.
    • Question: Would this change cause previously-passing TS files to start throwing compile errors.
      • Yes, that could happen - this was a potential runtime error in previous versions as it was implicit that window.fdc3 might not always be set (hence why we needed an fdc3Ready event).
      • @paulgoldsmith asked 'How do we decide what’s a breaking change?'
      • @kriswest: The Standards Working Group decides, usually on the recommendation of the FDC3 maintainers and Editors
      • @novavi: That sounds like it’s subjective
      • @kriswest Yes, and this PR is borderline
    • Needs a decision of the SWG - to be added ot the next SWG agenda
    • Make window.fdc3 optional #1386
      • Making window.fdc3 optional necessitates some changes in Methods.ts which developed compile errors
      • The meeting spent some time looking at the Method.ts tests and changes needed - there is small TypeScript syntax mystery to solve - details in the comments on the issue
  • Use TS Morph to generate type predicates #1387
    • @Roaders introduced the PR, which modifies the generated BrowserTypes.ts file after generation via post-processing with TSMorph.
      • Creates functions that can validate a message conforms to a particular schema
      • Creates 3 new unions representing the different classes of message
    • The schemas+quicktype already generate a type that represents the classes of message (AppRequestMessage, AgentResponseMessage, AgentEventMessage) but not as a union of the individual message types - rather each of those is single type with a union of strings in the type field, which is not as useful for discriminating messages.
    • @Roaders to explore not relying on the interface name to build the union types. If we could instead check that a given interface is logically compatible with AgentResponseMessage, AgentEventMessage or AppRequestMessage and use that to build the union types that would be better.
  • Rewrite channel selector to use updated message types #1345
    • There is a nest of PR’s that need to be wrangled when Rob gets back. Julianna is holding off on merging anything until after that time.
    • Fdc3 for web impl update #1392 may usurp some of the outstanding requests for 1345.
  • @kriswest reviewed the monorepo structure in FDC3 For Web Browsers Implementation DO NOT MERGE OR REVIEW #1309

Action Items

Untracked attendees

Full name Affiliation GitHub username
@kriswest kriswest added help wanted Extra attention is needed meeting labels Oct 16, 2024
@paulgoldsmith
Copy link

Paul Goldsmith / Morgan Stanley

@kriswest
Copy link
Contributor Author

Kris West / interop.io 🚀

@novavi
Copy link

novavi commented Oct 17, 2024

Derek Novavi / S&P Global

@julianna-ciq
Copy link
Contributor

Julianna Langston / interop.io

@Roaders
Copy link
Contributor

Roaders commented Oct 17, 2024

Giles Roadnight / Morgan Stanley 🚀

@openfin-johans
Copy link
Contributor

Johan Sandersson / Here 🎁

@VedPrakashJha-FMR
Copy link

VedPrakashJha-FMR / Fidelity Investments

@watson-ew
Copy link

Chris Watson / Elgin White 👋

@psmulovics
Copy link
Contributor

Peter Smulovics / Morgan Stanley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed meeting
Projects
None yet
Development

No branches or pull requests

9 participants