Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backwards compatibility support for the App Directory #553

Closed
ggeorgievx opened this issue Jan 18, 2022 · 1 comment · Fixed by #666 or #668
Closed

Add backwards compatibility support for the App Directory #553

ggeorgievx opened this issue Jan 18, 2022 · 1 comment · Fixed by #666 or #668
Labels
app-directory deprecation Deprecating or removing features post deprecation
Milestone

Comments

@ggeorgievx
Copy link
Member

PR #437 (issue #314) introduced a breaking change to the App Directory specification, namely changes to the Application schema. This issue suggests adding backwards compatibility to the specification by using the versioned URL end-points:

  • Introduce v2 end-points for all newly added changes
  • Add back the old Application schema and sort out any component naming issues
  • Mark the v1 end-points as optional/deprecated
@ggeorgievx ggeorgievx added app-directory deprecation Deprecating or removing features post deprecation labels Jan 18, 2022
@ggeorgievx ggeorgievx added this to the 2.0-candidates milestone Jan 18, 2022
@kriswest
Copy link
Contributor

I agree with this approach - we opted for the next version to be a major release in order to introduce breaking changes to the appD, but it makes sense to use the versioned URLs to make transitions easier and to keep the URLs aligned with the major version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-directory deprecation Deprecating or removing features post deprecation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants