Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure types are generated when new contexts are merged into master branch #749

Closed
kriswest opened this issue Jun 9, 2022 · 3 comments
Closed
Labels
api FDC3 API Working Group Context Data & Intents Contexts & Intents Discussion Group context-data FDC3 Context Data Working Group needs-pr project infrastructure

Comments

@kriswest
Copy link
Contributor

kriswest commented Jun 9, 2022

A PR (#747) is failing to build because it references another context type that was added in 2.0. In the PR the author has manually added the new context type with the reference. However, as types have not yet been generated for 2.0 (awaiting #745) the referenced type is missing.

Update the github actions to:

  • attempt to run type generation from context schemas on PRs (to check that they compile without error)
  • run type generation on merge to master as part of deployment, so that authors do NOT have to add the typescript manually, prior to deploying.
@kriswest kriswest added api FDC3 API Working Group context-data FDC3 Context Data Working Group project infrastructure Context Data & Intents Contexts & Intents Discussion Group labels Jun 9, 2022
@kriswest kriswest added this to the 2.0-release-tasks milestone Jun 9, 2022
@kriswest
Copy link
Contributor Author

kriswest commented Aug 4, 2022

Also consider releasing NPM module as a 'next' version with the newly generated types.

@kriswest
Copy link
Contributor Author

@kriswest
Copy link
Contributor Author

superseded by #940

@kriswest kriswest modified the milestones: 2.1-candidates, 2.2 candidates Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api FDC3 API Working Group Context Data & Intents Contexts & Intents Discussion Group context-data FDC3 Context Data Working Group needs-pr project infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants