-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fdc3 for web impl update #1392
Merged
Merged
Fdc3 for web impl update #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be consistent, both use ticker, 2. content data standard defines instrument with ticker
Signed-off-by: Yao, Yao <donghong.yao@fmr.com>
…-while-poc-fdc3 Clarify document while poc fdc3
…ttps/fdc3.finos.org/docs/next/api/spec fix Broken-link-in-https/fdc3.finos.org/docs/next/api/spec
Co-authored-by: Julianna Langston <74684272+julianna-ciq@users.noreply.github.com>
Co-authored-by: Julianna Langston <74684272+julianna-ciq@users.noreply.github.com>
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md) - [Commits](expressjs/express@4.19.2...4.21.0) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
… other intent docs
…ring of internal references
…xpress-4.21.0 Bump express from 4.19.2 to 4.21.0 in /website
Adjust colours
Set explicit background colours for website
Add missing id/name fields to context schema docs
from @hughtroeger's review Co-authored-by: Hugh Troeger <htroeger@factset.com>
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
Co-authored-by: Kris West <kris.west@interop.io>
591 - Adding CreateOrUpdateProfile intent
Support broadcast in FDC3 Action
Co-authored-by: Kris West <kris.west@interop.io>
console.error(`${resolution.source} returned a result error: ${error}`); | ||
try { | ||
const result = await resolution.getResult(); | ||
console.log(`${resolution.source} returned ${JSON.stringify(result)}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
console.log(`${resolution.source} returned ${JSON.stringify(result)}`); | |
console.log(resolution.source, " returned ", result); |
julianna-ciq
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving within the context of the addon changes.
11 tasks
Co-authored-by: Brian Ingenito <28159742+bingenito@users.noreply.github.com>
Make window.fdc3 optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges recent changes from the fdc3-for-web branch + main into fdc3-for-web-impl.
Fixes applied for: