Update CLI README.md #595
Open
Update CLI README.md #595
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #480
rocketstack-matt
requested review from
aidanm3341,
lbulanti-ms,
willosborne,
grahampacker-ms,
jpgough-ms and
Thels
as code owners
aidanm3341
reviewed
Nov 21, 2024
|
|
||
| ### Releasing the CLI | ||
|
|
||
| To deploy an updated version of the CLI to NPM run the [Publish to NPM](https://github.com/rocketstack-matt/architecture-as-code/actions/workflows/publish-cli-to-npm.yml) Action. |
There was a problem hiding this comment.
is manually running the action definitely the way we want this flow to work? It's currently setup to trigger when you do a GH release which I think is nicer since there is a clear history on the GH page itself (at least it should be, I recall you mentioning that you didn't think it was working, but the config is there)
There was a problem hiding this comment.
Hmmm - @rocketstack-matt can I pick up this issue off of you. I have a feeling the steps will of changed with moving to npm workspaces. I thought I had covered most of the use-cases but this appears to be another.
Thels
added a commit
to Thels/architecture-as-code
that referenced
this pull request
Nov 21, 2024
Also updated README to reflect how to trigger a release.
Thels
added a commit
that referenced
this pull request
Nov 21, 2024
#595 - updated action to work under workspaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #480