Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed change to the CDM for Equity Products #3163

Closed
winitall01 opened this issue Oct 7, 2024 · 1 comment · Fixed by #3199
Closed

Proposed change to the CDM for Equity Products #3163

winitall01 opened this issue Oct 7, 2024 · 1 comment · Fixed by #3199

Comments

@winitall01
Copy link
Contributor

winitall01 commented Oct 7, 2024

Issue 1: Activity Date

Problem Statement: Modelling of Activity Date in Create_TradeState Function is incomplete. Currently, activity date in empty in the function
Screenshot 2024-10-07 at 09 30 50

Proposal

Populate activity date with event Date
Screenshot 2024-10-07 at 09 32 53
This will also include making changes in all associated functions. Please refer to the following PR for full list of changes:

Issue 2: FpML Conditions require modification##

  1. FpML_ird_9
  2. FpML_ird_29

Current State
Screenshot 2024-10-07 at 09 40 24

Proposal

Proposed State
Screenshot 2024-10-07 at 09 39 15

Issue 3: Commodity Qualification function

Modifications to Qualify_AssetClass_Commodity and Qualify_Commodity_Forward
Addition of Single forwardPayoutLeg required
Current State
Screenshot 2024-10-07 at 21 58 49

Proposal

Proposed State
Screenshot 2024-10-07 at 21 59 02
Screenshot 2024-10-09 at 15 55 22

Issue 4: Equity Qualification function

Modifications to Qualify_AssetClass_Equity
Addition of AssetClass check for index underlier
Current State
Screenshot 2024-10-07 at 22 01 12

Proposal

Proposed State
Screenshot 2024-10-07 at 22 14 28

Issue 5: cardinality of expirationTime

Problem Statement: in type ExerciseTerms, expirationTime has a mandatory cardinality (1..1). For FX Options, there’s no fix expirationTime.
Current State
Screenshot 2024-10-07 at 22 03 13

Proposal

Proposal: relax expirationTime cardinality rule. Also, add a condition to require expirationTimeType when expirationTime exists or vice versa (to be added to AmericanExercise, BermudaExercise and EuropeanExercise)

Propos
Screenshot 2024-10-09 at 15 57 21
ed State

@manucarreramoreno
Copy link
Contributor

On Issue 3: Commodity Qualification function, why is the addition of a "Price Return Vanilla Forward" required? The attribute ForwardPayout does not allow the representation of a price, so we cannot determine at which price the commodity delivered is being payed (this is why we need to combine it with a fixedPricePayout or a commodityPayout)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment