-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update standardized-functions.md #3232
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for finos-cdm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice piece of documentation 👍
inputs: | ||
trade Trade (1..1) | ||
output: standardizedSchedule StandardizedSchedule (1..1) | ||
alias assetClass: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion, but by including the entire function in the documentation you are obligating yourself to update the documentation whenever the function changes. Where functions have been described in similar documents we tend to just put the function name, inputs and output to prevent this maintenance overhead.
assetClass StandardizedScheduleAssetClassEnum (1..1) | ||
durationInYears number (1..1) | ||
output: percentage number (1..1) | ||
set percentage: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as previous comment, it's nice to see the logic but really users should go into a modelling tool to review it
I won't add this comment to the other functions but its the same thing
@vallslaura build is still failing |
@PayalKhanna All checks have passed now, build failure has been solved. |
All good thanks |
Updated documentation, @PayalKhanna, solved issues.