From e0246e8336fcca167e1bc9d3762f2687793b4b05 Mon Sep 17 00:00:00 2001 From: Yannan <73408381+YannanGao-gs@users.noreply.github.com> Date: Fri, 22 Nov 2024 14:59:28 -0500 Subject: [PATCH] Fix rendering dependency funtions when loading using minimal graph --- .changeset/fluffy-camels-sparkle.md | 5 +++++ .changeset/lovely-bulldogs-bake.md | 3 +++ .../v1/V1_DSL_DataSpace_PureGraphManagerExtension.ts | 2 +- packages/legend-server-depot/src/DepotEntityHelper.ts | 9 +++++++-- 4 files changed, 16 insertions(+), 3 deletions(-) create mode 100644 .changeset/fluffy-camels-sparkle.md create mode 100644 .changeset/lovely-bulldogs-bake.md diff --git a/.changeset/fluffy-camels-sparkle.md b/.changeset/fluffy-camels-sparkle.md new file mode 100644 index 0000000000..68441729e9 --- /dev/null +++ b/.changeset/fluffy-camels-sparkle.md @@ -0,0 +1,5 @@ +--- +'@finos/legend-extension-dsl-data-space': patch +--- + +Fix rendering dependency funtions when loading using minimal graph diff --git a/.changeset/lovely-bulldogs-bake.md b/.changeset/lovely-bulldogs-bake.md new file mode 100644 index 0000000000..5e26d7324a --- /dev/null +++ b/.changeset/lovely-bulldogs-bake.md @@ -0,0 +1,3 @@ +--- +'@finos/legend-server-depot': patch +--- diff --git a/packages/legend-extension-dsl-data-space/src/graph-manager/protocol/pure/v1/V1_DSL_DataSpace_PureGraphManagerExtension.ts b/packages/legend-extension-dsl-data-space/src/graph-manager/protocol/pure/v1/V1_DSL_DataSpace_PureGraphManagerExtension.ts index d668fd38fa..a63fab8b8b 100644 --- a/packages/legend-extension-dsl-data-space/src/graph-manager/protocol/pure/v1/V1_DSL_DataSpace_PureGraphManagerExtension.ts +++ b/packages/legend-extension-dsl-data-space/src/graph-manager/protocol/pure/v1/V1_DSL_DataSpace_PureGraphManagerExtension.ts @@ -465,7 +465,7 @@ export class V1_DSL_DataSpace_PureGraphManagerExtension extends DSL_DataSpace_Pu } if (dependencyFunctionInfos.length > 0) { const dependencyFunctionInfoMap = new Map(); - functionInfos.forEach((funcInfo) => { + dependencyFunctionInfos.forEach((funcInfo) => { dependencyFunctionInfoMap.set(funcInfo.functionPath, funcInfo); }); dataSpaceAnalysisResult.dependencyFunctionInfos = diff --git a/packages/legend-server-depot/src/DepotEntityHelper.ts b/packages/legend-server-depot/src/DepotEntityHelper.ts index 4492eac5d4..74f8d15960 100644 --- a/packages/legend-server-depot/src/DepotEntityHelper.ts +++ b/packages/legend-server-depot/src/DepotEntityHelper.ts @@ -18,6 +18,7 @@ import type { StoreProjectData } from './models/StoreProjectData.js'; import type { EntitiesWithOrigin, Entity } from '@finos/legend-storage'; import type { DepotServerClient } from './DepotServerClient.js'; import type { PlainObject } from '@finos/legend-shared'; +import type { ProjectVersionEntities } from './models/ProjectVersionEntities.js'; export const retrieveProjectEntitiesWithDependencies = async ( project: StoreProjectData, @@ -45,7 +46,7 @@ export const retrieveProjectEntitiesWithClassifier = async ( ): Promise<[PlainObject[], PlainObject[]]> => { const [entities, dependencyEntities]: [ PlainObject[], - PlainObject[], + PlainObject[], ] = await Promise.all([ depotServerClient.getEntities(project, versionId, classifier), depotServerClient.getDependencyEntities( @@ -57,5 +58,9 @@ export const retrieveProjectEntitiesWithClassifier = async ( classifier, ), ]); - return [entities, dependencyEntities]; + + return [ + entities, + dependencyEntities.map((e) => e.entities).flat() as PlainObject[], + ]; };