Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for building graph from mapping analytics result #3657

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YannanGao-gs
Copy link
Contributor

Summary

Add testing for building graph from mapping analytics result

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@YannanGao-gs YannanGao-gs requested a review from a team as a code owner November 15, 2024 18:32
Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: 95c5651

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@finos/legend-graph Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-studio Patch
@finos/legend-code-editor Patch
@finos/legend-data-cube Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-lego Patch
@finos/legend-query-builder Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@YannanGao-gs YannanGao-gs self-assigned this Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 0.36%. Comparing base (dca547e) to head (95c5651).

Files with missing lines Patch % Lines
.../graph-manager/__test-utils__/EngineTestSupport.ts 0.00% 24 Missing ⚠️
...ph-manager/protocol/pure/v1/V1_PureGraphManager.ts 0.00% 8 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (dca547e) and HEAD (95c5651). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (dca547e) HEAD (95c5651)
7 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3657       +/-   ##
===========================================
- Coverage   45.48%    0.36%   -45.12%     
===========================================
  Files        2173     2171        -2     
  Lines      375773   375755       -18     
  Branches    16132     2250    -13882     
===========================================
- Hits       170908     1374   -169534     
- Misses     204171   372217   +168046     
- Partials      694     2164     +1470     
Files with missing lines Coverage Δ
...ph-manager/protocol/pure/v1/V1_PureGraphManager.ts 0.00% <0.00%> (-48.47%) ⬇️
.../graph-manager/__test-utils__/EngineTestSupport.ts 0.00% <0.00%> (ø)

... and 1471 files with indirect coverage changes

@YannanGao-gs YannanGao-gs marked this pull request as draft November 15, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant