Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI support for wavg #3676

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kelly-thai
Copy link
Contributor

@kelly-thai kelly-thai commented Nov 22, 2024

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@kelly-thai kelly-thai requested a review from a team as a code owner November 22, 2024 19:41
Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: efcb98d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 91.90476% with 34 lines in your changes missing coverage. Please review.

Project coverage is 45.18%. Comparing base (7d7a209) to head (efcb98d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ery-builder/src/stores/QueryBuilderStateBuilder.ts 13.33% 13 Missing ⚠️
...pure/v1/V1_QueryValueSpecificationBuilderHelper.ts 33.33% 12 Missing ⚠️
...on/operators/QueryBuilderAggregateOperator_Wavg.ts 97.05% 4 Missing ⚠️
...QueryBuilderProjectionValueSpecificationBuilder.ts 91.89% 3 Missing ⚠️
...omponents/fetch-structure/QueryBuilderAggParam.tsx 98.36% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3676      +/-   ##
==========================================
- Coverage   45.48%   45.18%   -0.31%     
==========================================
  Files        2179     2181       +2     
  Lines      377554   377970     +416     
  Branches    10440    16181    +5741     
==========================================
- Hits       171748   170784     -964     
- Misses     205360   206414    +1054     
- Partials      446      772     +326     
Files with missing lines Coverage Δ
...d-query-builder/src/__lib__/QueryBuilderTesting.ts 100.00% <100.00%> (ø)
...omponents/fetch-structure/QueryBuilderTDSPanel.tsx 83.16% <100.00%> (+0.07%) ⬆️
...ry-builder/src/graph/QueryBuilderMetaModelConst.ts 100.00% <100.00%> (ø)
...y-builder/src/stores/QueryBuilderStateHashUtils.ts 100.00% <100.00%> (ø)
...aggregation/QueryBuilderAggregateOperatorLoader.ts 100.00% <100.00%> (ø)
...aggregation/QueryBuilderAggregationStateBuilder.ts 98.85% <100.00%> (+0.28%) ⬆️
...ds/projection/QueryBuilderProjectionColumnState.ts 77.97% <100.00%> (+0.35%) ⬆️
...omponents/fetch-structure/QueryBuilderAggParam.tsx 98.36% <98.36%> (ø)
...QueryBuilderProjectionValueSpecificationBuilder.ts 85.55% <91.89%> (+0.45%) ⬆️
...on/operators/QueryBuilderAggregateOperator_Wavg.ts 97.05% <97.05%> (ø)
... and 2 more

... and 175 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant