Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering dependency funtions when loading using minimal graph #3677

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YannanGao-gs
Copy link
Contributor

@YannanGao-gs YannanGao-gs commented Nov 22, 2024

Summary

fix deserializing dependency function entities

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@YannanGao-gs YannanGao-gs requested a review from a team as a code owner November 22, 2024 19:46
Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: 7b40a85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@finos/legend-extension-dsl-data-space Patch
@finos/legend-server-depot Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-application-studio Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-query-builder Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 45.58%. Comparing base (da82302) to head (7b40a85).

Files with missing lines Patch % Lines
...kages/legend-server-depot/src/DepotEntityHelper.ts 0.00% 7 Missing ⚠️
...e/v1/V1_DSL_DataSpace_PureGraphManagerExtension.ts 0.00% 1 Missing ⚠️
...stores/query-builder/DataSpaceQueryBuilderState.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3677      +/-   ##
==========================================
+ Coverage   45.54%   45.58%   +0.03%     
==========================================
  Files        2179     2179              
  Lines      377554   377560       +6     
  Branches    16229    16278      +49     
==========================================
+ Hits       171947   172100     +153     
+ Misses     204603   204442     -161     
- Partials     1004     1018      +14     
Files with missing lines Coverage Δ
...e/v1/V1_DSL_DataSpace_PureGraphManagerExtension.ts 14.49% <0.00%> (ø)
...stores/query-builder/DataSpaceQueryBuilderState.ts 0.00% <0.00%> (ø)
...kages/legend-server-depot/src/DepotEntityHelper.ts 0.00% <0.00%> (ø)

... and 100 files with indirect coverage changes

---- 🚨 Try these New Features:

@YannanGao-gs YannanGao-gs changed the title fix deserializing dependency function entities Fix rendering dependency funtions when loading using minimal graph Nov 22, 2024
@YannanGao-gs YannanGao-gs self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant