Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to upgrade clang-format #2834

Closed
ArashPartow opened this issue Nov 7, 2024 · 1 comment
Closed

Need to upgrade clang-format #2834

ArashPartow opened this issue Nov 7, 2024 · 1 comment

Comments

@ArashPartow
Copy link
Contributor

ArashPartow commented Nov 7, 2024

Bug Report

When running the lint pipeline, an error is raised by clang-format about a particular config option, which leads to the check not being run, yet the jobs completes with no issues. Error message:

 /home/runner/work/perspective/perspective/.clang-format:25:5: error: unknown enumerated scalar
    Enabled: false
    ^

It's related to the following section:

AlignConsecutiveMacros:
    Enabled: false

This particular section of the config it seems requires a more recent version of clang-format.

More details: llvm/llvm-project#56407

@texodus
Copy link
Member

texodus commented Nov 27, 2024

clang-format is not a project-managed dependency and this is covered in the developer docs though admittedly not prominently enough. I'm unaware of a way to make this requirement more oblique, suggestions welcome in PR form though I'm going to close this issue to prevent chatbot PRs.

@texodus texodus closed this as completed Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants