Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms of service and privacy policy did not show on email auth UI process. #1090

Closed
shortstopyomin opened this issue Jan 4, 2018 · 7 comments

Comments

@shortstopyomin
Copy link

FirebaseUI-Android (Version: 3.1.2) sample code without changing any source code.

Terms of service and privacy policy did not show on email auth UI process.

master branch.

public void signIn(View view) {
        startActivityForResult(
                AuthUI.getInstance().createSignInIntentBuilder()
                        .setTheme(getSelectedTheme())
                        .setLogo(getSelectedLogo())
                        .setAvailableProviders(getSelectedProviders())
                        .setTosUrl(getSelectedTosUrl())
                        .setPrivacyPolicyUrl(getSelectedPrivacyPolicyUrl())
                        .setIsSmartLockEnabled(mEnableCredentialSelector.isChecked(),
                                mEnableHintSelector.isChecked())
                        .setAllowNewEmailAccounts(mAllowNewEmailAccounts.isChecked())
                        .build(),
                RC_SIGN_IN);
    }
@Kurt29
Copy link

Kurt29 commented Jan 4, 2018

I am not sure and cannot try it for my own, but can you try the same code withouts setting a custom theme?

@samtstern
Copy link
Contributor

@shortstopyomin could you please show a screenshot of what you see when you expect to see the TOS?

@shortstopyomin
Copy link
Author

@samtstern

screenshot_20180104-190103

@samtstern samtstern added this to the 3.2.0 milestone Jan 8, 2018
@samtstern
Copy link
Contributor

@shortstopyomin thanks for the screenshot, I have sent a PR to fix this #1094

@borrom-dev
Copy link

borrom-dev commented Jan 19, 2018

I'm quite new to open source project, but I was wondering when this fixed will available?

@samtstern
Copy link
Contributor

@borrom-dev we're hoping to release 3.2.0 soon, probably early next week.

@samtstern
Copy link
Contributor

This has been fixed and released in version 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants