Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touch area issue on some UI elements (38dp -> 48dp) #1415

Closed
peterhav opened this issue Aug 23, 2018 · 2 comments
Closed

Touch area issue on some UI elements (38dp -> 48dp) #1415

peterhav opened this issue Aug 23, 2018 · 2 comments
Assignees
@samtstern
Labels
auth fix-implemented type: feature request
Milestone
4.2.1

Comments

@peterhav
Copy link
Contributor

  • Android device: all
  • Android OS version: all
  • FirebaseUI version: 4.1.0

Step 3: Describe the problem:

Steps to reproduce:

After uploading the app to Google Play, the automatically created pre-launch reports state that some clickable parts of the Firebase UI have a too small size (38dp, should be 48dp).

Observed Results:

firebase_ui_toucharea

Expected Results:

Firebase-UI should not give any problems in the pre-launch reports of Google Play.
@samtstern
Copy link
Contributor

@peterhav thanks for flagging this! Looks like this might be solved by adding some vertical padding to those text views to get them up to 48dp? Or do you suggest something else?

@samtstern samtstern added this to the 4.2.1 milestone Sep 18, 2018
@samtstern samtstern mentioned this issue Oct 23, 2018
Merged
@samtstern samtstern self-assigned this Oct 23, 2018
@samtstern
Copy link
Contributor

This has been fixed and released in version 4.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samtstern samtstern

Labels
auth fix-implemented type: feature request
Projects
None yet
Milestone
4.2.1
Development

No branches or pull requests
2 participants
@peterhav @samtstern