Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui_localizations): Add Norwegian (NB) localization #191

Merged
merged 9 commits into from
Dec 19, 2023

Conversation

ovestoerholt
Copy link
Contributor

Description

Adds Norwegian localization.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@lesnitsky
Copy link
Member

@ovestoerholt could you please ask someone else who speaks Norwegian to proofread this PR and approve it?

@arnsteinkjellevold
Copy link

My native language is Norwegian and have proofread and can vouch for this translation.

@lesnitsky
Copy link
Member

@ovestoerholt please also update packages/firebase_ui_localizations/lib/src/all_languages.dart so thatnb is correctly picked up

@ovestoerholt
Copy link
Contributor Author

@lesnitsky Added 👍

@@ -3,6 +3,8 @@
// BSD-style license that can be found in the LICENSE file.
import 'dart:ui';

import 'package:firebase_ui_localizations/src/lang/nb.dart';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please follow the same style for imports as the rest of the languages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Copy link
Member

@lesnitsky lesnitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error - lib/src/lang/nb.dart:6:7 - Missing concrete implementations of 'getter FirebaseUILocalizationLabels.confirmDeleteAccountAlertMessage', 'getter FirebaseUILocalizationLabels.confirmDeleteAccountAlertTitle', and 'getter FirebaseUILocalizationLabels.confirmDeleteAccountButtonLabel'. Try implementing the missing methods, or make the class abstract. - non_abstract_class_inherits_abstract_member

Seems like there are a few missing keys.

@ovestoerholt
Copy link
Contributor Author

Strange... Will have a look 👍

@ovestoerholt
Copy link
Contributor Author

ovestoerholt commented Dec 4, 2023

Ok. Found new additions in main. Will update 👍

@ovestoerholt
Copy link
Contributor Author

@lesnitsky Please try now 👍

@lesnitsky lesnitsky merged commit 715ab1b into firebase:main Dec 19, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants