Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_ui_auth): add showPasswordVisibilityToggle to RegisterScreen #297

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

kzrnm
Copy link
Contributor

@kzrnm kzrnm commented Feb 26, 2024

Description

Currently, showPasswordVisibilityToggle is available on SignInScreen, but not on RegisterScreen.

Related Issues

#114

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@kzrnm kzrnm changed the title Add showPasswordVisibilityToggle to RegisterScreen fix(firebase_ui_auth): add showPasswordVisibilityToggle to RegisterScreen Feb 26, 2024
@russellwheatley
Copy link
Member

@kzrnm - this seems a nice update. Could you merge with main branch, please?

@kzrnm
Copy link
Contributor Author

kzrnm commented Mar 13, 2024

@russellwheatley I have merged with main.

@russellwheatley russellwheatley changed the title fix(firebase_ui_auth): add showPasswordVisibilityToggle to RegisterScreen feat(firebase_ui_auth): add showPasswordVisibilityToggle to RegisterScreen Mar 14, 2024
@russellwheatley russellwheatley merged commit 6ec3ec1 into firebase:main Mar 14, 2024
11 of 14 checks passed
@kzrnm kzrnm deleted the register_password_visibility branch March 14, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants