-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is sendEachForMulticast thread safe #950
Comments
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
The method should not have any thread issue, because to achieve high notification throughput, we need to call the method in multiple thread. In production, we are using the predecessor "sendmulticast" method with 6+ thread to achieve 80k+ rpm on one java process. And we didn't face with any thread safety issue. |
When using FCM admin SDK v9.3.0
|
It is normal :). |
Closing this as this will be addressed in #979 |
I was going through the
sendEachForMulticast
logic and didn't find anything to tell if it's thread safe or not, my current implementation is by calling the following in a new threadFirebaseMessaging.getInstance().sendEachForMulticast(message)
Am I messing something here ? is my implementation thread safe ?
The text was updated successfully, but these errors were encountered: