Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support passing google.auth typed credentials in initialize_app() #821

Merged
merged 3 commits into from
Nov 4, 2024
Merged

feat: Support passing google.auth typed credentials in initialize_app() #821

merged 3 commits into from
Nov 4, 2024
+30 −2

Conversation

jonathanedey
Copy link
Contributor

@jonathanedey jonathanedey commented Oct 24, 2024 •
edited
Loading

Fixes: #698

@jonathanedey jonathanedey marked this pull request as ready for review October 28, 2024 15:27
@lahirumaramba lahirumaramba added release-note release:stage Stage a release candidate labels Nov 4, 2024
lahirumaramba
lahirumaramba approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jonathanedey jonathanedey merged commit 32e8dd2 into master Nov 4, 2024
13 checks passed
@jonathanedey jonathanedey deleted the je-auth-cred branch November 4, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@jonathanedey jonathanedey

Labels
release:stage Stage a release candidate release-note
Projects
None yet
Milestone
No milestone
2 participants
@jonathanedey @lahirumaramba